chore(cleanup): address TODOs PE-7339 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #296 +/- ##
===========================================
+ Coverage 94.40% 94.41% +0.01%
===========================================
Files 10 10
Lines 3001 3007 +6
===========================================
+ Hits 2833 2839 +6
Misses 168 168 ☔ View full report in Codecov by Sentry. |
dtfiedler
force-pushed
the
PE-7339-review-todos
branch
from
129c19d to
b808106
Compare
added 5 commits
January 3, 2025 08:23
dtfiedler
changed the title
|
Pushed several more commits to address other outstanding TODOs. Will address the remaining in individual PRs. |
|
dtfiedler
approved these changes
Jan 3, 2025
|
|
||
| --- Factory function for creating an "AOEvent" | ||
| --- @param initialData table<string, any> Optional initial data to populate the event with. | ||
| --- @returns AOEvent |
| --- Convenience factory function for pre populating analytic and msg fields into AOEvents | ||
| --- @param msg table | ||
| --- @param initialData table<string, any> Optional initial data to populate the event with. | ||
| --- @returns ARIOEvent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR addresses some of the TODOs. We still have 23 in the codebase, quite a few around improved testing coverage
removes timestamp conversion (looks good so far, test this devnet)<-- did not blend, we need this converisonName